leesf commented on a change in pull request #1045: [HUDI-209] Implement JMX
metrics reporter
URL: https://github.com/apache/incubator-hudi/pull/1045#discussion_r350198077
##########
File path:
hudi-client/src/main/java/org/apache/hudi/metrics/MetricsReporter.java
##########
@@ -28,7 +29,7 @@
/**
* Push out metrics at scheduled intervals
*/
- public abstract void start();
+ public abstract void start() throws IOException;
Review comment:
Would you please remove the `throws IOException` too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
