pratyakshsharma commented on a change in pull request #1050: [HUDI-368]: code
clean up in TestAsyncCompaction class
URL: https://github.com/apache/incubator-hudi/pull/1050#discussion_r350702988
##########
File path: hudi-client/src/test/java/org/apache/hudi/TestAsyncCompaction.java
##########
@@ -352,15 +338,15 @@ public void
testScheduleCompactionWithOlderOrSameTimestamp() throws Exception {
public void testCompactionAfterTwoDeltaCommits() throws Exception {
// No Delta Commits after compaction request
HoodieWriteConfig cfg = getConfig(true);
- try (HoodieWriteClient client = getHoodieWriteClient(cfg, true);) {
+ try (HoodieWriteClient client = getHoodieWriteClient(cfg, true)) {
String firstInstantTime = "001";
String secondInstantTime = "004";
String compactionInstantTime = "005";
int numRecs = 2000;
List<HoodieRecord> records = dataGen.generateInserts(firstInstantTime,
numRecs);
- records = runNextDeltaCommits(client, Arrays.asList(firstInstantTime,
secondInstantTime), records, cfg, true,
Review comment:
assigning the value to records is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
