bvaradar commented on a change in pull request #1062: [HUDI-294] Delete Paths 
written in Cleaner plan needs to be relative to partition-path
URL: https://github.com/apache/incubator-hudi/pull/1062#discussion_r352769861
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/AvroUtils.java
 ##########
 @@ -52,8 +56,12 @@
 
   private static final Integer DEFAULT_VERSION = 1;
 
-  public static HoodieCleanMetadata convertCleanMetadata(String 
startCleanTime, Option<Long> durationInMs,
-      List<HoodieCleanStat> cleanStats) {
+  public static final Integer CLEAN_METADATA_VERSION_1 = 
CleanV1MigrationHandler.VERSION;
 
 Review comment:
   I think its better to move these constants along with convertCleanMetadata 
method to a new class CleanerUtils in the same package just like 
CompactionUtils ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to