vinothchandar commented on a change in pull request #1073: [WIP] [HUDI-377]
Adding Delete() support to DeltaStreamer
URL: https://github.com/apache/incubator-hudi/pull/1073#discussion_r353188392
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/OverwriteWithLatestAvroPayload.java
##########
@@ -60,7 +60,18 @@ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload
@Override
public Option<IndexedRecord> combineAndGetUpdateValue(IndexedRecord
currentValue, Schema schema) throws IOException {
// combining strategy here trivially ignores currentValue on disk and
writes this record
- return getInsertValue(schema);
+ Object deleteMarker = null;
+ try {
+ deleteMarker = DataSourceUtils.getNestedFieldVal(
+ genericRecord, "_hoodie_delete_marker");
+ } catch (HoodieException e) {
Review comment:
is there a better way to detect not found than throwing an exception.. this
happens in the fast path, so may not be ideal to do it, this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
