nsivabalan commented on a change in pull request #1073: [WIP] [HUDI-377] Adding
Delete() support to DeltaStreamer
URL: https://github.com/apache/incubator-hudi/pull/1073#discussion_r353349031
##########
File path:
hudi-spark/src/main/java/org/apache/hudi/OverwriteWithLatestAvroPayload.java
##########
@@ -60,7 +60,18 @@ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload
@Override
public Option<IndexedRecord> combineAndGetUpdateValue(IndexedRecord
currentValue, Schema schema) throws IOException {
// combining strategy here trivially ignores currentValue on disk and
writes this record
- return getInsertValue(schema);
+ Object deleteMarker = null;
Review comment:
yes. OverwriteWithLatestAvroPayload is configurable right? What incase some
user changes this to something else, then deletes in delta streamer may not
work as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
