bvaradar commented on a change in pull request #1009: [HUDI-308] Avoid Renames
for tracking state transitions of all actions on dataset
URL: https://github.com/apache/incubator-hudi/pull/1009#discussion_r350889000
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieCleanClient.java
##########
@@ -92,7 +92,7 @@ protected HoodieCleanMetadata clean(String startCleanTime)
throws HoodieIOExcept
if ((cleanerPlan.getFilesToBeDeletedPerPartition() != null)
&& !cleanerPlan.getFilesToBeDeletedPerPartition().isEmpty()) {
final HoodieTable<T> hoodieTable =
HoodieTable.getHoodieTable(createMetaClient(true), config, jsc);
- return runClean(hoodieTable, startCleanTime);
+ return runClean(hoodieTable,
HoodieTimeline.getCleanRequestedInstant(startCleanTime), cleanerPlan);
Review comment:
No, it only creates a Requested instant. The loop earlier in the same
function will take care of inflight clean instants
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
