bvaradar commented on a change in pull request #1009: [HUDI-308] Avoid Renames for tracking state transitions of all actions on dataset URL: https://github.com/apache/incubator-hudi/pull/1009#discussion_r354245375
########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java ########## @@ -30,7 +34,23 @@ * * @see HoodieTimeline */ -public class HoodieInstant implements Serializable { +public class HoodieInstant implements Serializable, Comparable<HoodieInstant> { + + /** + * A COMPACTION action eventually becomes COMMIT when completed. So, when grouping instants + * for state transitions, this needs to be taken into account + */ + private static final Set<String> comparableActions = Arrays.stream(new String[] { HoodieTimeline.COMMIT_ACTION, Review comment: Added a jira to track this : https://jira.apache.org/jira/browse/HUDI-384 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services