[GitHub] [incubator-hudi] nisheet195 commented on a change in pull request #1090: [HUDI-390] Add backtick character in hive queries to support hive identiter as tablename

[GitBox]

nisheet195 commented on a change in pull request #1090: [HUDI-390] Add backtick 
character in hive queries to support hive identiter as tablename
URL: https://github.com/apache/incubator-hudi/pull/1090#discussion_r356014371
 
 

 ##########
 File path: hudi-hive/src/main/java/org/apache/hudi/hive/util/SchemaUtil.java
 ##########
 @@ -402,7 +402,7 @@ public static String generateCreateDDL(MessageType 
storageSchema, HiveSyncConfig
 
     String partitionsStr = 
partitionFields.stream().collect(Collectors.joining(","));
     StringBuilder sb = new StringBuilder("CREATE EXTERNAL TABLE  IF NOT EXISTS 
");
-    sb = sb.append(config.databaseName).append(".").append(config.tableName);
+    sb = 
sb.append("`").append(config.databaseName).append("`.`").append(config.tableName).append("`");
 
 Review comment:
   Moved it to a variable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services