vinothchandar commented on a change in pull request #1009: [HUDI-308] Avoid Renames for tracking state transitions of all actions on dataset URL: https://github.com/apache/incubator-hudi/pull/1009#discussion_r357181681
########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/TimelineLayout.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table; + +import org.apache.hudi.common.model.TimelineLayoutVersion; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.util.collection.Pair; + +import java.io.Serializable; +import java.util.HashMap; +import java.util.Map; +import java.util.stream.Collectors; +import java.util.stream.Stream; + + +/** + * Timeline Layout responsible for applying specific filters when generating timeline instants. + */ +public abstract class TimelineLayout implements Serializable { + + private static final Map<TimelineLayoutVersion, TimelineLayout> LAYOUT_MAP = new HashMap<>(); + + static { + LAYOUT_MAP.put(new TimelineLayoutVersion(TimelineLayoutVersion.VERSION_0), new TimelineLayoutV0()); + LAYOUT_MAP.put(new TimelineLayoutVersion(TimelineLayoutVersion.VERSION_1), new TimelineLayoutV1()); + } + + public static TimelineLayout getLayout(TimelineLayoutVersion version) { + return LAYOUT_MAP.get(version); + } + + public abstract Stream<HoodieInstant> filterHoodieInstants(Stream<HoodieInstant> instantStream); + + /** + * Table Layout where state transitions are managed by renaming files. + */ + private static class TimelineLayoutV0 extends TimelineLayout { Review comment: lets add a small unit tests for this, if it doesnot exist already ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
