bschell commented on a change in pull request #1091: [HUDI-389] Fixing Index
look up to return right partitions for a given key along with fileId with
Global Bloom
URL: https://github.com/apache/incubator-hudi/pull/1091#discussion_r357365653
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/bloom/ListBasedGlobalIndexFileFilter.java
##########
@@ -35,17 +36,14 @@
}
@Override
- public Set<String> getMatchingFiles(String partitionPath, String recordKey) {
- Set<String> toReturn = new HashSet<>();
- partitionToFileIndexInfo.values().forEach(indexInfos -> {
- if (indexInfos != null) { // could be null, if there are no files in a
given partition yet.
- // for each candidate file in partition, that needs to be compared.
- for (BloomIndexFileInfo indexInfo : indexInfos) {
- if (shouldCompareWithFile(indexInfo, recordKey)) {
- toReturn.add(indexInfo.getFileId());
- }
+ public Set<Pair<String, String>> getMatchingFilesAndPartition(String
partitionPath, String recordKey) {
+ Set<Pair<String, String>> toReturn = new HashSet<>();
+ partitionToFileIndexInfo.forEach((parition, bloomIndexFileInfoList) -> {
Review comment:
[nit] parition -> partition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
