[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1091: [HUDI-389] Fixing Index look up to return right partitions for a given key along with fileId with Global Bloom

[GitBox]

nsivabalan commented on a change in pull request #1091: [HUDI-389] Fixing Index 
look up to return right partitions for a given key along with fileId with 
Global Bloom
URL: https://github.com/apache/incubator-hudi/pull/1091#discussion_r357852751
 
 

 ##########
 File path: 
hudi-client/src/main/java/org/apache/hudi/index/bloom/IntervalTreeBasedGlobalIndexFileFilter.java
 ##########
 @@ -58,10 +67,12 @@
   }
 
   @Override
-  public Set<String> getMatchingFiles(String partitionPath, String recordKey) {
-    Set<String> toReturn = new HashSet<>();
-    toReturn.addAll(indexLookUpTree.getMatchingIndexFiles(recordKey));
-    toReturn.addAll(filesWithNoRanges);
+  public Set<Pair<String, String>> getMatchingFilesAndPartition(String 
partitionPath, String recordKey) {
+    Set<String> matchingFiles = new HashSet<>();
 
 Review comment:
   Are you suggesting something like this
   
   Stream<String> matchingFiles = Stream.concat(filesWithNoRanges.stream(), 
indexLookUpTree.getMatchingIndexFiles(recordKey).stream());
       Set<Pair<String, String>> toReturn = new HashSet<>();
       matchingFiles.forEach(file -> 
toReturn.add(Pair.of(fileToPartitionPathMap.get(file), file)));
       return toReturn;

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services