garyli1019 opened a new pull request #1113: [HUDI-415] Get commit time when 
Spark start
URL: https://github.com/apache/incubator-hudi/pull/1113
 
 
   ## Why do I create this PR
   
   The current `HoodieSparkSqlWriter` record the `commitTime` after checking 
the input `hoodieRecords` is not empty. `isEmpty()` is a Spark action that will 
trigger all the transformations before this. So if we do some heavy Spark 
transformation before writing as Hudi dataset, the commit time will be the time 
that `isEmpty()` was finished, instead of the time we start the Spark job.
   So I am making this PR to move the commit time to the beginning of the Spark 
job.
   
   ## What is the purpose of the pull request
   
   *This pull request move the commit time to the beginning of Spark job*
   
   ## Brief change log
   
     - Modify write in HoodieSparkSqlWriter
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test 
coverage.
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to