vinothchandar commented on a change in pull request #1105: [HUDI-405] Fix sync
no hive partition at first time
URL: https://github.com/apache/incubator-hudi/pull/1105#discussion_r359136457
##########
File path: hudi-hive/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -75,6 +75,7 @@
public class HoodieHiveClient {
private static final String HOODIE_LAST_COMMIT_TIME_SYNC =
"last_commit_time_sync";
+ private static final String HOODIE_FIRST_COMMIT_TIME = "0";
Review comment:
Instead of special casing like this, we can change the method you call to
`findPartitionsAfter(HoodieTimeline)` and pass `activeTimeline` in `if` and
`activeTimeline.findInstantsAfter(lastCommitTimeSynced, Integer.MAX_VALUE)` in
the `else`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
