nsivabalan commented on a change in pull request #1111: [HUDI-331]Fix java docs
for all public apis in HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1111#discussion_r360442861
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -509,13 +522,21 @@ private Partitioner getPartitioner(HoodieTable table,
boolean isUpsert, Workload
/**
* Commit changes performed at the given commitTime marker.
+ *
+ * @param commitTime Commit Time handle
+ * @param writeStatuses RDD of WriteStatus to inspect errors and counts
+ * @return true if commit successfully
*/
public boolean commit(String commitTime, JavaRDD<WriteStatus> writeStatuses)
{
return commit(commitTime, writeStatuses, Option.empty());
}
/**
* Commit changes performed at the given commitTime marker.
+ * @param commitTime Commit Time handle
+ * @param writeStatuses RDD of WriteStatus to inspect errors and counts
+ * @param extraMetadata Extra Metadata to be stored
+ * @return true if commit successfully
Review comment:
same comment as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
