hddong commented on a change in pull request #1114: [HUDI-438] Merge duplicated
code fragment
URL: https://github.com/apache/incubator-hudi/pull/1114#discussion_r360699643
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -85,7 +84,7 @@ private[hudi] object HoodieSparkSqlWriter {
// Running into issues wrt generic type conversion from Java to Scala.
Couldn't make common code paths for
// write and deletes. Specifically, instantiating client of type
HoodieWriteClient<T extends HoodieRecordPayload>
// is having issues. Hence some codes blocks are same in both if and else
blocks.
- if (!operation.equalsIgnoreCase(DELETE_OPERATION_OPT_VAL)) {
+ val writeSuccessful = if
(!operation.equalsIgnoreCase(DELETE_OPERATION_OPT_VAL)) {
Review comment:
> can you remove the above comment
Move to checkWriteStatus's javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
