vinothchandar commented on a change in pull request #1109: [HUDI-238] -
Migrating to Scala 2.12
URL: https://github.com/apache/incubator-hudi/pull/1109#discussion_r360719714
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -22,53 +22,51 @@
import org.apache.hudi.common.util.Option;
import org.apache.hudi.common.util.TypedProperties;
import org.apache.hudi.exception.HoodieNotSupportedException;
-import org.apache.hudi.utilities.exception.HoodieDeltaStreamerException;
-import kafka.common.TopicAndPartition;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.common.serialization.StringDeserializer;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
-import org.apache.spark.streaming.kafka.KafkaCluster;
-import org.apache.spark.streaming.kafka.KafkaCluster.LeaderOffset;
-import org.apache.spark.streaming.kafka.OffsetRange;
+import org.apache.spark.streaming.kafka010.OffsetRange;
import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
import java.util.HashMap;
import java.util.HashSet;
+import java.util.List;
+import java.util.Random;
+import java.util.Set;
import java.util.stream.Collectors;
-import scala.Predef;
-import scala.collection.JavaConverters;
-import scala.collection.immutable.Map;
-import scala.collection.immutable.Set;
-import scala.collection.mutable.ArrayBuffer;
import scala.collection.mutable.StringBuilder;
-import scala.util.Either;
/**
* Source to read data from Kafka, incrementally.
*/
public class KafkaOffsetGen {
- private static final Logger LOG = LogManager.getLogger(KafkaOffsetGen.class);
+ private static volatile Logger log =
LogManager.getLogger(KafkaOffsetGen.class);
public static class CheckpointUtils {
/**
* Reconstruct checkpoint from string.
*/
- public static HashMap<TopicAndPartition, KafkaCluster.LeaderOffset>
strToOffsets(String checkpointStr) {
- HashMap<TopicAndPartition, KafkaCluster.LeaderOffset> offsetMap = new
HashMap<>();
+ public static HashMap<TopicPartition, Long> strToOffsets(String
checkpointStr) {
Review comment:
would this be backwards compatible with existing checkpoints? Seems like it
will. just confirming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
