vinothchandar commented on a change in pull request #1091: [HUDI-389] Fixing
Index look up to return right partitions for a given key along with fileId with
Global Bloom
URL: https://github.com/apache/incubator-hudi/pull/1091#discussion_r360731336
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/bloom/IntervalTreeBasedGlobalIndexFileFilter.java
##########
@@ -58,10 +67,12 @@
}
@Override
- public Set<String> getMatchingFiles(String partitionPath, String recordKey) {
- Set<String> toReturn = new HashSet<>();
- toReturn.addAll(indexLookUpTree.getMatchingIndexFiles(recordKey));
- toReturn.addAll(filesWithNoRanges);
+ public Set<Pair<String, String>> getMatchingFilesAndPartition(String
partitionPath, String recordKey) {
+ Set<String> matchingFiles = new HashSet<>();
Review comment:
Instead of forEach we can do a `collect(Collectors.toSet)` .. It's fine to
leave it as-is. just a cosmetic suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
