nsivabalan commented on issue #1073: [HUDI-377] Adding Delete() support to DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1073#issuecomment-568823739 > Is it also necessary to let `HoodieAvroPayload` support delete api too? > > https://github.com/apache/incubator-hudi/blob/8172197c353ff6cda491120c41b2d14b412ad709/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroPayload.java#L44 > > > Maybe like this: > ```java > Object deleteMarker = record.get().get("_hoodie_delete_marker"); > if (deleteMarker instanceof Boolean && (boolean) deleteMarker) { > this.recordBytes = new byte[0]; > } else { > this.recordBytes = HoodieAvroUtils.avroToBytes(record.get()); > } > ``` Don't think it is required. if I am not wrong, combineAndUpdate will make the payload empty.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
