cdmikechen commented on issue #1075: [HUDI-114]: added option to overwrite 
payload implementation in hoodie.properties file
URL: https://github.com/apache/incubator-hudi/pull/1075#issuecomment-568866635
 
 
   Can I ask an additional question?
   I found in first commit hudi will init table type in hoodie.properties.
   
https://github.com/apache/incubator-hudi/blob/313fab5fd1ef715f98a123d0e09f6010daacab68/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#L126
   And this code link to 
   
https://github.com/apache/incubator-hudi/blob/9a1f698eef1044443adadbf7a1bf7b5eb94fb84e/hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java#L286-L290
   Then link to 
   
https://github.com/apache/incubator-hudi/blob/9a1f698eef1044443adadbf7a1bf7b5eb94fb84e/hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java#L300-L318
   Does this mean that no matter what user set `payloadClassName`, hudi always 
recognize 
`HoodieTableConfig.HOODIE_PAYLOAD_CLASS_PROP_NAME`(`hoodie.compaction.payload.class`)
 as default value? Should it be fixed
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to