vinothchandar commented on a change in pull request #1106: [HUDI-209] Implement
JMX metrics reporter
URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r361340278
##########
File path: hudi-client/src/main/java/org/apache/hudi/metrics/Metrics.java
##########
@@ -47,7 +48,7 @@ private Metrics(HoodieWriteConfig metricConfig) {
if (reporter == null) {
throw new RuntimeException("Cannot initialize Reporter.");
}
- // reporter.start();
+ reporter.start();
Review comment:
you mean commented? can you try git blaming the lines and see if there are
any clues.. IIRC, there was some issue that made us do this? I am not tbh ..
uncommenting looks reasonable to me, but better to fully understand the context
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
