leesf commented on issue #1135: [HUDI-233]Redo log statements using SLF4J URL: https://github.com/apache/incubator-hudi/pull/1135#issuecomment-568937528 Thanks for opening the PR @listenLearning . Here are my some thoughts. - we must ensure the log4j paly well with spark/hive/presto to avoid version conflicts, more context [here](https://issues.apache.org/jira/projects/HUDI/issues/HUDI-233?filter=allopenissues). - so please verify it in your own cluster to ensure the modification is correct. - only replace the `LogManager.getLogger` with `LogFactory.getLogger` is incompleted, you need replace the `LOG.info,LOG.error,LOG.debug` statement in the project also. - IMHO, I would like to suggest redo log statements module by module.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
