vinothchandar commented on a change in pull request #1073: [HUDI-377] Adding
Delete() support to DeltaStreamer
URL: https://github.com/apache/incubator-hudi/pull/1073#discussion_r361342980
##########
File path:
hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
##########
@@ -148,27 +169,27 @@ public static void createCommitFile(String basePath,
String commitTime) throws I
public static void createCommitFile(String basePath, String commitTime,
Configuration configuration) {
Arrays.asList(HoodieTimeline.makeCommitFileName(commitTime),
HoodieTimeline.makeInflightCommitFileName(commitTime),
HoodieTimeline.makeRequestedCommitFileName(commitTime)).forEach(f -> {
- Path commitFile = new Path(
- basePath + "/" + HoodieTableMetaClient.METAFOLDER_NAME + "/" +
f);
- FSDataOutputStream os = null;
+ Path commitFile = new Path(
+ basePath + "/" + HoodieTableMetaClient.METAFOLDER_NAME + "/" + f);
+ FSDataOutputStream os = null;
+ try {
+ FileSystem fs = FSUtils.getFs(basePath, configuration);
+ os = fs.create(commitFile, true);
+ HoodieCommitMetadata commitMetadata = new HoodieCommitMetadata();
+ // Write empty commit metadata
+ os.writeBytes(new
String(commitMetadata.toJsonString().getBytes(StandardCharsets.UTF_8)));
+ } catch (IOException ioe) {
+ throw new HoodieIOException(ioe.getMessage(), ioe);
+ } finally {
+ if (null != os) {
try {
- FileSystem fs = FSUtils.getFs(basePath, configuration);
Review comment:
seems like this is just an indentation change? or has code changed here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
