[ 
https://issues.apache.org/jira/browse/HUDI-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004624#comment-17004624
 ] 

Balaji Varadarajan commented on HUDI-417:
-----------------------------------------

[~nicholasjiang]: Sorry, I didnt get a chance to respond to your question. I am 
back from vacation. This is an initial step as it would make it easy to have 
further changes done with less conflicts. I will take it up as I have cycles 
tonight to get it done. As per earlier discussion, the spark datasource support 
task is not in the critical path for now but it would be great if you can start 
looking into it right away.

> Refactor HoodieWriteClient so that commit logic can be shareable by both 
> bootstrap and normal write operations
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HUDI-417
>                 URL: https://issues.apache.org/jira/browse/HUDI-417
>             Project: Apache Hudi (incubating)
>          Issue Type: Sub-task
>          Components: Writer Core
>            Reporter: Balaji Varadarajan
>            Priority: Major
>             Fix For: 0.5.1
>
>
>  
> Basic Code Changes are present in the fork : 
> [https://github.com/bvaradar/hudi/tree/vb_bootstrap]
>  
> The current implementation of HoodieBootstrapClient has duplicate code for 
> committing bootstrap. 
> [https://github.com/bvaradar/hudi/blob/vb_bootstrap/hudi-client/src/main/java/org/apache/hudi/bootstrap/HoodieBootstrapClient.java]
>  
>  
> We can have an independent PR which would move these commit functionality 
> from HoodieWriteClient to a new base class AbstractHoodieWriteClient which 
> HoodieBootstrapClient can inherit.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to