yanghua commented on a change in pull request #1145: [HUDI-455] Redo
hudi-client log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1145#discussion_r361834900
##########
File path: hudi-client/pom.xml
##########
@@ -85,6 +85,11 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>1.7.28</version>
Review comment:
Since we will introduce the slf4j, IMO, we should extract the version of
this dependency to the parent pom file and let other modules introduce the same
version number. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
