[
https://issues.apache.org/jira/browse/HUDI-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pratyaksh Sharma updated HUDI-402:
----------------------------------
Description:
DataSourceUtils.java -
In function getNestedFieldValAsString, we call getNestedFieldVal function to
get the value. Then we check if the object returned is null, which is always
false, since the called function throws an exception rather than returning
null.
Need to change the code accordingly.
Test classes -
# We have defined checked exceptions at a lot of places which are actually not
thrown anywhere.
# Similarly, java stream code can be refactored at a lot of places.
was:
In function getNestedFieldValAsString, we call getNestedFieldVal function to
get the value. Then we check if the object returned is null, which is always
false, since the called function throws an exception rather than returning
null.
Need to change the code accordingly.
> Code clean up in DataSourceUtils.java and all test classes
> ----------------------------------------------------------
>
> Key: HUDI-402
> URL: https://issues.apache.org/jira/browse/HUDI-402
> Project: Apache Hudi (incubating)
> Issue Type: Improvement
> Components: Code Cleanup
> Reporter: Pratyaksh Sharma
> Assignee: Pratyaksh Sharma
> Priority: Major
> Fix For: 0.5.1
>
>
> DataSourceUtils.java -
> In function getNestedFieldValAsString, we call getNestedFieldVal function to
> get the value. Then we check if the object returned is null, which is always
> false, since the called function throws an exception rather than returning
> null.
> Need to change the code accordingly.
> Test classes -
> # We have defined checked exceptions at a lot of places which are actually
> not thrown anywhere.
> # Similarly, java stream code can be refactored at a lot of places.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
