pratyakshsharma opened a new pull request #1153: [HUDI-402]: code clean up in 
test classes and DataSourceUtils.java class
URL: https://github.com/apache/incubator-hudi/pull/1153
 
 
   DataSourceUtils.java - 
   
   In function getNestedFieldValAsString, we call getNestedFieldVal function to 
get the value. Then we check if the object returned is null, which is always 
false, since the called function throws an exception rather than returning 
null. 
   
   Need to change the code accordingly.
   
   Test classes - 
   
   We have defined checked exceptions at a lot of places which are actually not 
thrown anywhere. 
   Similarly, java stream code can be refactored at a lot of places. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to