yanghua commented on a change in pull request #1156: [HUDI-482] Fix missing
@Override annotation on method
URL: https://github.com/apache/incubator-hudi/pull/1156#discussion_r361887878
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -879,12 +883,14 @@ public void createPool(JobConf conf, PathFilter...
filters) {
return (CombineFileSplit[]) inputSplitShims.toArray(new
HadoopShimsSecure.InputSplitShim[inputSplitShims.size()]);
}
+ @Override
public HadoopShimsSecure.InputSplitShim getInputSplitShim() throws
IOException {
return new HadoopShimsSecure.InputSplitShim();
}
+ @Override
public RecordReader getRecordReader(JobConf job, CombineFileSplit split,
Reporter reporter,
- Class<RecordReader<K, V>> rrClass) throws IOException {
+ Class<RecordReader<K, V>> rrClass)
throws IOException {
Review comment:
Can you check the indentation is correct? Based on the "one PR one thing"
convention, it would be better to revert this change. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
