dengziming commented on a change in pull request #1158: [MINOR]: alter some
wrong params which bring fatal exception
URL: https://github.com/apache/incubator-hudi/pull/1158#discussion_r361977514
##########
File path: hudi-client/src/test/java/HoodieClientExample.java
##########
@@ -95,7 +95,7 @@ public void run() throws Exception {
HoodieWriteConfig cfg = HoodieWriteConfig.newBuilder().withPath(tablePath)
.withSchema(HoodieTestDataGenerator.TRIP_EXAMPLE_SCHEMA).withParallelism(2,
2).forTable(tableName)
.withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(IndexType.BLOOM).build())
-
.withCompactionConfig(HoodieCompactionConfig.newBuilder().archiveCommitsWith(2,
3).build()).build();
+
.withCompactionConfig(HoodieCompactionConfig.newBuilder().archiveCommitsWith(20,
30).build()).build();
Review comment:
if we set minToKeep=2, the app will exit with
`java.lang.IllegalArgumentException: Increase hoodie.keep.min.commits=2 to be
greater than hoodie.cleaner.commits.retained=10. Otherwise, there is risk of
incremental pull missing data from few instants`.
just set to DEFAULT_MIN_COMMITS_TO_KEEP and DEFAULT_MAX_COMMITS_TO_KEEP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
