lamber-ken commented on a change in pull request #1143: [MINOR] Fix out of
limits for results
URL: https://github.com/apache/incubator-hudi/pull/1143#discussion_r362153348
##########
File path:
hudi-cli/src/main/java/org/apache/hudi/cli/commands/HoodieLogFileCommand.java
##########
@@ -215,9 +215,11 @@ public String showLogFileRecords(
if (n instanceof HoodieAvroDataBlock) {
HoodieAvroDataBlock blk = (HoodieAvroDataBlock) n;
List<IndexedRecord> records = blk.getRecords();
- allRecords.addAll(records);
- if (allRecords.size() >= limit) {
- break;
+ for (IndexedRecord record : records) {
+ if (allRecords.size() >= limit) {
Review comment:
Reasonable, 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
