leesf commented on a change in pull request #1183: [HUDI-460] Redo
hudi-integ-test log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1183#discussion_r363303802
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -239,9 +239,9 @@ private void saveUpLogs() {
executeCommandStringInDocker(HIVESERVER, "cat /tmp/root/hive.log",
true).getStdout().toString();
String filePath = System.getProperty("java.io.tmpdir") + "/" +
System.currentTimeMillis() + "-hive.log";
FileIOUtils.writeStringToFile(hiveLogStr, filePath);
- LOG.info("Hive log saved up at : " + filePath);
+ LOG.info("Hive log saved up at : {}", filePath);
} catch (Exception e) {
- LOG.error("Unable to save up logs..", e);
+ LOG.error("Unable to save up logs.. {}", e);
Review comment:
could use `LOG.error("Unable to save up logs.", e);` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
