n3nash commented on a change in pull request #1194: [HUDI-326] Add support to delete records with only record_key URL: https://github.com/apache/incubator-hudi/pull/1194#discussion_r365046553
########## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/GlobalDeleteKeyGenerator.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.keygen; + +import java.util.Arrays; +import java.util.List; +import org.apache.avro.generic.GenericRecord; +import org.apache.hudi.DataSourceUtils; +import org.apache.hudi.DataSourceWriteOptions; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.util.TypedProperties; +import org.apache.hudi.exception.HoodieKeyException; + +/** + * Key generator for deletes using global indices. Global index deletes do not require partition value + * so this key generator avoids using partition value for generating HoodieKey. + */ +public class GlobalDeleteKeyGenerator extends KeyGenerator { + + private static final String EMPTY_PARTITION = ""; + private static final String NULL_RECORDKEY_PLACEHOLDER = "__null__"; Review comment: If the recordkey is "null" what is the advantage of creating a record with this string ? There wouldn't be any records with that value in the first place right ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
