bvaradar commented on a change in pull request #1157: [HUDI-332]Add operation
type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#discussion_r365069589
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -492,6 +501,11 @@ protected void postCommit(HoodieCommitMetadata metadata,
String instantTime,
}
}
+ @Override
+ protected void updateOperationType(HoodieCommitMetadata metadata) {
Review comment:
If we move the operationType instance to base-class, you no longer need this
overridden method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services