hmatu commented on a change in pull request #1207: [HUDI-458] Redo
hudi-hadoop-mr log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1207#discussion_r365496880
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java
##########
@@ -144,30 +143,32 @@ public boolean accept(Path path) {
if (!hoodiePathCache.containsKey(folder.toString())) {
hoodiePathCache.put(folder.toString(), new HashSet<>());
}
- LOG.info("Based on hoodie metadata from base path: " +
baseDir.toString() + ", caching " + latestFiles.size()
- + " files under " + folder);
+ LOG.info("Based on hoodie metadata from base path: {}, caching {}
files under {}",
+ baseDir,
+ latestFiles.size(),
+ folder);
for (HoodieDataFile lfile : latestFiles) {
hoodiePathCache.get(folder.toString()).add(new
Path(lfile.getPath()));
}
// accept the path, if its among the latest files.
if (LOG.isDebugEnabled()) {
- LOG.debug(String.format("%s checked after cache population, accept
=> %s \n", path,
- hoodiePathCache.get(folder.toString()).contains(path)));
+ LOG.debug("{} checked after cache population, accept => {} \n",
path,
+ hoodiePathCache.get(folder.toString()).contains(path));
}
return hoodiePathCache.get(folder.toString()).contains(path);
} catch (DatasetNotFoundException e) {
// Non-hoodie path, accept it.
if (LOG.isDebugEnabled()) {
- LOG.debug(String.format("(1) Caching non-hoodie path under %s \n",
folder.toString()));
+ LOG.debug("(1) Caching non-hoodie path under {} \n", folder);
Review comment:
Remove `\n`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
