smarthi commented on a change in pull request #1094: [WIP] [HUDI-375] Refactor
the configure framework of hudi project
URL: https://github.com/apache/incubator-hudi/pull/1094#discussion_r365619752
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -739,4 +728,113 @@ public HoodieWriteConfig build() {
return config;
}
}
+
+ //
--------------------------------------------------------------------------------
+ // ------------------------ ConfigOption Part
-----------------------------------
+ //
--------------------------------------------------------------------------------
+
+ public void setString(ConfigOption<String> option, String value) {
+ Preconditions.checkArgument(option != null);
+ Preconditions.checkArgument(value != null);
Review comment:
Replace all Preconditions.checkArgument() with
ValidationUtils.checkArgument() <--- once the PR for that has been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
