vinothchandar commented on a change in pull request #1212: [WIP] [HUDI-509]
Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r366207936
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -160,9 +160,9 @@ public Operation convert(String value) throws
ParameterException {
@Parameter(names = {"--target-table"}, description = "name of the target
table in Hive", required = true)
public String targetTableName;
- @Parameter(names = {"--storage-type"}, description = "Type of Storage.
COPY_ON_WRITE (or) MERGE_ON_READ",
+ @Parameter(names = {"--table-type"}, description = "Type of table.
COPY_ON_WRITE (or) MERGE_ON_READ",
Review comment:
I tried retaining `--storage-type` as well. but have to choose betwen this
and the new `--table-type`to mark as required.. Whichever we pick, it wont be
ideal. So choose to simply rename, requiring the users to make a small change
in the command, when upgrading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
