bvaradar commented on issue #1109: [HUDI-238] - Migrating to Scala 2.12 URL: https://github.com/apache/incubator-hudi/pull/1109#issuecomment-574944571 > > @ezhux : I see a bunch of earlier comments. Some of these are addressed in PR #1226 . Do you think you will be able to address the changes in this PR in a day so that we can land it by friday (Sunday is the release cutoff date). If not, we can focus on landing PR #1226 ( cc @ezhux ) > > @zhedoubushishi : Thanks for opening another diff. > > @ezhux @zhedoubushishi : After spending sometime playing with maven to pull off cross-compiling, i think it is easier to go with profile approach (e:g : in spark -2.4.4 setup - https://github.com/apache/spark/blob/branch-2.4/external/avro/pom.xml and profile definition in base pom : https://github.com/apache/spark/blob/branch-2.4/pom.xml#L2797 > > The main change we need would to rename hudi-spark to hudi-spark_2.11 for 2.11 and hudi-spark_2.12 (when run with overridden profile. Same for hudi-spark-bundle and hudi-utilities-bundle ? > > If this works, we can change the release process to generate jars for both 2.11 and 2.12. Let me know your thoughts. > > I am trying to use the Spark way to support Scala 2.12. (https://spark.apache.org/docs/latest/building-spark.html) > > To build Hudi with Scala 2.12, first change the major Scala version using (e.g. 2.12): > > ``` > dev/change-scala-version.sh 2.12 > ``` > > Then build with Maven: > > ``` > mvn -Pscala-2.12 clean install > ``` > > Is this the way you want? @zhedoubushishi : lets discuss more in PR #1226 . To your question, yes that should be fine. In addition, can you rename the module in hudi-spark/pom.xml to hudi-spark_${scala.binary.version} or if not possible hudi-spark_2.11 to be default but then have dev/change_scala_version.sh to handle it ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
