zhedoubushishi commented on a change in pull request #1226: [HUDI-238] Make
Hudi support Scala 2.12
URL: https://github.com/apache/incubator-hudi/pull/1226#discussion_r367250686
##########
File path: docker/hoodie/hadoop/hive_base/pom.xml
##########
@@ -57,10 +57,10 @@
<tasks>
<copy
file="${project.basedir}/../../../../packaging/hudi-hadoop-mr-bundle/target/hudi-hadoop-mr-bundle-${project.version}.jar"
tofile="target/hoodie-hadoop-mr-bundle.jar" />
<copy
file="${project.basedir}/../../../../packaging/hudi-hive-bundle/target/hudi-hive-bundle-${project.version}.jar"
tofile="target/hoodie-hive-bundle.jar" />
- <copy
file="${project.basedir}/../../../../packaging/hudi-spark-bundle/target/hudi-spark-bundle-${project.version}.jar"
tofile="target/hoodie-spark-bundle.jar" />
+ <copy
file="${project.basedir}/../../../../packaging/hudi-spark-bundle/target/hudi-spark-bundle_${scala.binary.version}-${project.version}.jar"
tofile="target/hoodie-spark-bundle_${scala.binary.version}.jar" />
Review comment:
> @zhedoubushishi : You are on right track. Don't add scala version to the
target jars inside docker. The docker setup has hard-wired this configuration.
Removing the version from "tofile" entry should hopefully have the tests pass.
Thanks for your advise. I'll have a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
