boneanxs commented on a change in pull request #4586:
URL: https://github.com/apache/hudi/pull/4586#discussion_r785450167
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieSourceOffset.scala
##########
@@ -26,7 +26,7 @@ import org.apache.spark.sql.execution.streaming.{Offset,
SerializedOffset}
case class HoodieSourceOffset(commitTime: String) extends Offset {
- override def json(): String = {
+ override val json: String = {
Review comment:
This just is an improve change, json no need to recalculate when calling
this again, as it's value can not be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
