xushiyan commented on a change in pull request #3745:
URL: https://github.com/apache/hudi/pull/3745#discussion_r786538718
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -366,50 +368,50 @@ object HoodieSparkSqlWriter {
}
- // Handle various save modes
if (mode == SaveMode.Ignore && tableExists) {
log.warn(s"hoodie table at $basePath already exists. Ignoring & not
performing actual writes.")
false
} else {
+ // Handle various save modes
handleSaveModes(sqlContext.sparkSession, mode, basePath, tableConfig,
tableName, WriteOperationType.BOOTSTRAP, fs)
- }
Review comment:
this comment is redundant; it just repeats the method name. we should
just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]