codope commented on a change in pull request #3962:
URL: https://github.com/apache/hudi/pull/3962#discussion_r787301127
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -529,6 +529,7 @@ object HoodieSparkSqlWriter {
val hiveSyncConfig: HiveSyncConfig = buildSyncConfig(basePath,
hoodieConfig, sqlConf)
val hiveConf: HiveConf = new HiveConf()
hiveConf.addResource(fs.getConf)
+
hiveConf.set(HiveConf.ConfVars.METASTOREURIS.varname,hiveSyncConfig.metastoreUris)
Review comment:
What if `hive.metastore.uris` is already set in hive conf and it is
different from what user passed as hive sync config? Should we add a validation
here?
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -387,6 +387,11 @@ object DataSourceWriteOptions {
val HIVE_URL: ConfigProperty[String] = ConfigProperty
.key("hoodie.datasource.hive_sync.jdbcurl")
.defaultValue("jdbc:hive2://localhost:10000")
+ .withDocumentation("Hive jdbc url")
+
+ val METASTORE_URIS: ConfigProperty[String] = ConfigProperty
+ .key("hoodie.datasource.hive_sync.metastore.uris")
+ .defaultValue("thrift:localhost:9083")
Review comment:
Shouldn't this be `thrift://localhost:9083` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
