nsivabalan commented on a change in pull request #4605: URL: https://github.com/apache/hudi/pull/4605#discussion_r789064143
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/RestoreUtils.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.table.action.restore; + +import org.apache.hudi.avro.model.HoodieRestorePlan; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.table.timeline.HoodieTimeline; +import org.apache.hudi.common.table.timeline.TimelineMetadataUtils; + +import java.io.IOException; + +public class RestoreUtils { + + /** + * Get Latest version of Restore plan corresponding to a restore instant. + * + * @param metaClient Hoodie Table Meta Client + * @param restoreInstant Instant referring to restore action + * @return Rollback plan corresponding to rollback instant + * @throws IOException + */ + public static HoodieRestorePlan getRestorePlan(HoodieTableMetaClient metaClient, HoodieInstant restoreInstant) + throws IOException { + // TODO: add upgrade step if required. Review comment: yes. but here is what I am thinking. since restore has to be done via hudi-cli anyways, may be we should not recommend upgrading a hudi table with a pending restore. let the user ensure restore is complete. or can delete the restore instants and retry after upgrade is complete. lets jam on this to get a consensus. Can take it as a follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
