nsivabalan commented on a change in pull request #4606:
URL: https://github.com/apache/hudi/pull/4606#discussion_r789257773
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java
##########
@@ -190,15 +190,7 @@
.withDocumentation("When rewriting data, preserves existing
hoodie_commit_time");
/**
- * Using space-filling curves to optimize the layout of table to boost query
performance.
- * The table data which sorted by space-filling curve has better aggregation;
- * combine with min-max filtering, it can achieve good performance
improvement.
- *
- * Notice:
- * when we use this feature, we need specify the sort columns.
- * The more columns involved in sorting, the worse the aggregation, and the
smaller the query performance improvement.
- * Choose the filter columns which commonly used in query sql as sort
columns.
- * It is recommend that 2 ~ 4 columns participate in sorting.
+ * @deprecated this setting has no effect
Review comment:
can you add in documentation as to what other config(s) the user is
supposed to look into instead of this deprecated one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
