dongkelun commented on pull request #3644: URL: https://github.com/apache/hudi/pull/3644#issuecomment-1019660788
> changes in general is good. just 1 nit. Can we try to see if we can leverage HoodieTestDataGenerator to write tests. you can do something like this dataGen.generateInserts : batch1 dataGen.generateUpdates : batch2 if not for allowDuplicates config set, total record count in snapshot view will be just batch1 records (assuming we updated all records from batch1) if config is set to true, total record count in snapshot view will be batch1 records + batch2 records. and you can do some assertions to ensure both batch of records are present. OK, I'll try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
