xushiyan commented on a change in pull request #3893:
URL: https://github.com/apache/hudi/pull/3893#discussion_r794618101
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java
##########
@@ -18,21 +18,21 @@
package org.apache.hudi.common.model;
-import java.util.Map;
-import java.util.stream.Collectors;
-import java.util.stream.IntStream;
import org.apache.hudi.common.util.CollectionUtils;
import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.Pair;
import java.io.Serializable;
import java.util.List;
+import java.util.Map;
import java.util.Objects;
-import org.apache.hudi.common.util.collection.Pair;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
/**
* A Single Record managed by Hoodie.
*/
-public class HoodieRecord<T extends HoodieRecordPayload> implements
Serializable {
+public abstract class HoodieRecord<T> implements Serializable {
Review comment:
@alexeykudinkin so the main goal here is to make `HoodieRecord`
independent of `HoodieRecordPayload`, this will allow `HoodieRowRecord` to be
used by row-writer code path. `HoodieAvroRecord` is also meant for
compatibility with existing codebase and ease the decoupling. Yea we should
discuss more about HoodieAvroRecord vs SparkHoodieRecord.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
