yihua commented on a change in pull request #4556:
URL: https://github.com/apache/hudi/pull/4556#discussion_r794852662
##########
File path:
hudi-common/src/main/scala/org/apache/hudi/HoodieTableFileIndexBase.scala
##########
@@ -87,6 +89,12 @@ abstract class HoodieTableFileIndexBase(engineContext:
HoodieEngineContext,
refresh0()
+ /**
+ * Returns latest completed instant as seen by this instance of the
file-index
+ */
+ def latestCompletedInstant(): Option[HoodieInstant] =
Review comment:
I'm trying to understand if this `def function` is more like a `val`
function or method in a class. If it acts like a function, it can be defined
as a `val` function (`val latestCompletedInstant = () =>
getActiveTimeline.filterCompletedInstants().lastInstant()`) and such naming is
fine. If it's more like a method, `getLatestCompletedInstant()` naming is
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
