satishkotha opened a new pull request #1274: [HUDI-571] Add 'commits show 
archived' command to CLI
URL: https://github.com/apache/incubator-hudi/pull/1274
 
 
   
   ## What is the purpose of the pull request
   
   Add command to show archived commits. This is useful for debugging 
historical timeline. 
   
   ## Brief change log
   - There is already 'show archived commits' command, but the output is not at 
all useful. Refactor common timeline methods to HoodieDefaultTimeline to reuse 
between Active and Archived timeline to make archived commits look similar to 
active commits
   - Modify tests to use archived timeline instead of reading files explicitly
   - Note that there is no pagination/lazy loading support and if a really long 
time range is specified, this can result in OOM. To keep the diff small, I'm 
sending this one first. After I get feedback, i can send another diff to 
support lazy loading (or pagination). 
   
   ## Verify this pull request
   
   
   This pull request is already covered by existing tests, such as:
     - TestHoodieCommitArchiveLog.java
     - Manually verified the change by running CLI locally. Example output:
   `hoodie:$dataset->commits show archived
   
    
__________________________________________________________________________________________________________________________________________________________________________
       | CommitTime    | Total Bytes Written| Total Files Added| Total Files 
Updated| Total Partitions Written| Total Records Written| Total Update Records 
Written| Total Errors|
       
|=========================================================================================================================================================================|
       | 20200113224332| 45.7 GB            | 0                | 86             
    | 4                       | 97806475             | 107538                   
   | 0           |
       | 20200113223441| 840.5 MB           | 0                | 1618           
    | 258                     | 1214615              | 15512                    
   | 0           |
       | 20200113223441| 840.5 MB           | 0                | 1618           
    | 258                     | 1214615              | 15512                    
   | 0           |`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to