alexeykudinkin commented on a change in pull request #3893:
URL: https://github.com/apache/hudi/pull/3893#discussion_r795917358
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
##########
@@ -60,7 +57,7 @@ protected HoodieIndex(HoodieWriteConfig config) {
@Deprecated
@PublicAPIMethod(maturity = ApiMaturityLevel.DEPRECATED)
public I tagLocation(I records, HoodieEngineContext context,
- HoodieTable<T, I, K, O> hoodieTable) throws
HoodieIndexException {
+ HoodieTable hoodieTable) throws HoodieIndexException {
Review comment:
As general rule of thumb, i think we should aim to fix all raw-types
occurrences in the code-base.
Can you please fix new instances so that we at least don't add to our debt?
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java
##########
@@ -18,21 +18,21 @@
package org.apache.hudi.common.model;
-import java.util.Map;
-import java.util.stream.Collectors;
-import java.util.stream.IntStream;
import org.apache.hudi.common.util.CollectionUtils;
import org.apache.hudi.common.util.Option;
+import org.apache.hudi.common.util.collection.Pair;
import java.io.Serializable;
import java.util.List;
+import java.util.Map;
import java.util.Objects;
-import org.apache.hudi.common.util.collection.Pair;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
/**
* A Single Record managed by Hoodie.
*/
-public class HoodieRecord<T extends HoodieRecordPayload> implements
Serializable {
+public abstract class HoodieRecord<T> implements Serializable {
Review comment:
Discussed offline: this will be an intermediate state until RFC-46 is
fully implemented
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java
##########
@@ -70,7 +67,7 @@ public I tagLocation(I records, HoodieEngineContext context,
@Deprecated
@PublicAPIMethod(maturity = ApiMaturityLevel.DEPRECATED)
public O updateLocation(O writeStatuses, HoodieEngineContext context,
- HoodieTable<T, I, K, O> hoodieTable) throws
HoodieIndexException {
+ HoodieTable hoodieTable) throws HoodieIndexException
{
Review comment:
Here as well
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/hbase/SparkHoodieHBaseIndex.java
##########
@@ -385,7 +384,7 @@ private void doMutations(BufferedMutator mutator,
List<Mutation> mutations, Rate
mutations.clear();
}
- public Map<String, Integer>
mapFileWithInsertsToUniquePartition(JavaRDD<WriteStatus> writeStatusRDD) {
+ Map<String, Integer>
mapFileWithInsertsToUniquePartition(JavaRDD<WriteStatus> writeStatusRDD) {
Review comment:
Since we don't want to depend on Guava we can add our own annotation
with the same purpose as `@VisibleForTesting`
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.common.model;
+
+public class HoodieAvroRecord<T extends HoodieRecordPayload> extends
HoodieRecord<T> {
Review comment:
Discussed offline: this will be an intermediate state until RFC-46 is
fully implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
