alexeykudinkin commented on a change in pull request #4716:
URL: https://github.com/apache/hudi/pull/4716#discussion_r796210413



##########
File path: hudi-common/src/main/avro/HoodieRollbackMetadata.avsc
##########
@@ -38,14 +38,6 @@
                     "type": "long",
                     "doc": "Size of this file in bytes"
                 }
-            }], "default":null },

Review comment:
       This is an excerpt from Avro's docs:
   https://avro.apache.org/docs/1.7.7/spec.html#Schema+Resolution
   <img width="1339" alt="Screen Shot 2022-01-31 at 5 42 02 PM" 
src="https://user-images.githubusercontent.com/428277/151900978-a62c84d6-3bb7-4723-bdfd-c8d937689c34.png";>
   
   
   

##########
File path: hudi-common/src/main/avro/HoodieRollbackMetadata.avsc
##########
@@ -38,14 +38,6 @@
                     "type": "long",
                     "doc": "Size of this file in bytes"
                 }
-            }], "default":null },

Review comment:
       I've researched this a bit since my intuition was telling that fields 
removal is BWC change in Avro (since Avro also supports _forward 
compatibility_, when you essentially read data with old schema that was 
produced with a new one, which is essentially the same case)
   
   And seems like deletion is BWC in Avro:
   https://docs.confluent.io/platform/current/schema-registry/avro.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to