alexeykudinkin commented on a change in pull request #4333:
URL: https://github.com/apache/hudi/pull/4333#discussion_r796909001
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieLogFile.java
##########
@@ -60,7 +59,7 @@ public HoodieLogFile(FileStatus fileStatus) {
public HoodieLogFile(Path logPath) {
this.fileStatus = null;
this.pathStr = logPath.toString();
- this.fileLen = 0;
+ this.fileLen = -1;
Review comment:
So the file len of 0 is very confusing it could be a legitimate case. I
had to go and check whether file was indeed of length 0.
Setting it to -1 makes it clear that this is not initialized and can't be
used as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
