alexeykudinkin commented on a change in pull request #4667:
URL: https://github.com/apache/hudi/pull/4667#discussion_r799902667
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java
##########
@@ -54,20 +45,16 @@
*/
@UseRecordReaderFromInputFormat
@UseFileSplitsFromInputFormat
-public class HoodieParquetInputFormat extends HoodieFileInputFormatBase
implements Configurable {
+public class HoodieParquetInputFormat extends HoodieParquetInputFormatBase {
private static final Logger LOG =
LogManager.getLogger(HoodieParquetInputFormat.class);
- // NOTE: We're only using {@code MapredParquetInputFormat} to compose
vectorized
- // {@code RecordReader}
- private final MapredParquetInputFormat mapredParquetInputFormat = new
MapredParquetInputFormat();
-
- protected HoodieDefaultTimeline filterInstantsTimeline(HoodieDefaultTimeline
timeline) {
- return HoodieInputFormatUtils.filterInstantsTimeline(timeline);
+ public HoodieParquetInputFormat() {
+ super(new HoodieCopyOnWriteTableInputFormat());
Review comment:
B/c there's no point in that indirection -- we can go straight to the
super class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]